Re: [PATCH 4.19 066/133] regmap: debugfs: Dont sleep while atomic for fast_io regmaps

[Pavel Machek]

Hi!

> From: Douglas Anderson <dianders@xxxxxxxxxxxx>
> 
> [ Upstream commit 299632e54b2e692d2830af84be51172480dc1e26 ]
>

> +	err = kstrtobool_from_user(user_buf, count, &new_val);
> +	/* Ignore malforned data like debugfs_write_file_bool() */

> +	err = kstrtobool_from_user(user_buf, count, &new_val);
> +	/* Ignore malforned data like debugfs_write_file_bool() */

I guess that should be "malformed" in both cases.

Plus it would not be bad to share code between those two functions, as
they are pretty much identical...

Best regards,
								Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: PGP signature