Re: [PATCH] OMAP: iommu: check for failure of a call to omap_iommu_dump_ctx

From: Joerg Roedel
Date: Wed Jul 22 2020 - 09:03:13 EST


On Tue, Jul 14, 2020 at 08:22:11PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> It is possible for the call to omap_iommu_dump_ctx to return
> a negative error number, so check for the failure and return
> the error number rather than pass the negative value to
> simple_read_from_buffer.
>
> Addresses-Coverity: ("Improper use of negative value")
> Fixes: 14e0e6796a0d ("OMAP: iommu: add initial debugfs support")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> ---
> drivers/iommu/omap-iommu-debug.c | 3 +++
> 1 file changed, 3 insertions(+)

Applied, thanks.