Re: [PATCH][next] i2c: designware: Use fallthrough pseudo-keyword

[Gustavo A. R. Silva]

On Wed, Jul 22, 2020 at 11:52:56AM +0300, Andy Shevchenko wrote:
> On Wed, Jul 22, 2020 at 2:48 AM Gustavo A. R. Silva
> <gustavoars@xxxxxxxxxx> wrote:
> >
> > Replace the existing /* fall through */ comments and its variants with
> > the new pseudo-keyword macro fallthrough[1].
> 
> Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> 
> 
> > [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
> 
> Perhaps you may do it as Link: tag?
> 

mmh... that's a good suggestion; thanks, Andy.

--
Gustavo

> > Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>
> > ---
> >  drivers/i2c/busses/i2c-designware-pcidrv.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c b/drivers/i2c/busses/i2c-designware-pcidrv.c
> > index 8522134f9ea9..55c83a7a24f3 100644
> > --- a/drivers/i2c/busses/i2c-designware-pcidrv.c
> > +++ b/drivers/i2c/busses/i2c-designware-pcidrv.c
> > @@ -90,7 +90,7 @@ static int mfld_setup(struct pci_dev *pdev, struct dw_pci_controller *c)
> >         switch (pdev->device) {
> >         case 0x0817:
> >                 dev->timings.bus_freq_hz = I2C_MAX_STANDARD_MODE_FREQ;
> > -               /* fall through */
> > +               fallthrough;
> >         case 0x0818:
> >         case 0x0819:
> >                 c->bus_num = pdev->device - 0x817 + 3;
> > --
> > 2.27.0
> >
> 
> 
> -- 
> With Best Regards,
> Andy Shevchenko