Re: [Linux-kernel-mentees] [PATCH net] AX.25: Prevent out-of-bounds read in ax25_sendmsg()

From: David Miller
Date: Wed Jul 22 2020 - 21:07:26 EST


From: Peilin Ye <yepeilin.cs@xxxxxxxxx>
Date: Wed, 22 Jul 2020 12:05:12 -0400

> Checks on `addr_len` and `usax->sax25_ndigis` are insufficient.
> ax25_sendmsg() can go out of bounds when `usax->sax25_ndigis` equals to 7
> or 8. Fix it.
>
> It is safe to remove `usax->sax25_ndigis > AX25_MAX_DIGIS`, since
> `addr_len` is guaranteed to be less than or equal to
> `sizeof(struct full_sockaddr_ax25)`
>
> Signed-off-by: Peilin Ye <yepeilin.cs@xxxxxxxxx>

Applied.