Re: [PATCH v1] clk: Export __clk_lookup()

[elaine.zhang]

在 2020/7/23 上午2:26, Heiko Stuebner 写道:
> Hi Elaine,
>
> Am Mittwoch, 22. Juli 2020, 04:32:30 CEST schrieb Elaine Zhang:
> > Export __clk_lookup() to support user built as module.
> >
> > ERROR:
> > drivers/clk/rockchip/clk.ko: In function
> > `rockchip_clk_protect_critical':
> > drivers/clk/rockchip/clk.c:741:
> > undefined reference to `__clk_lookup'
> can you elaborate a bit more on why this would be needed?
>
> Because right now the Rockchip clocks are of course built into
> the main kernel image (especially due to them being needed during early
> boot) and __clk_lookup actually is a pretty deep part of the clock-
> framework itself, as probably also denoted by the "__" in the function
> name.

Rockchip clocks are of course support to built as module(to support GKI),These changes will be pushed soon.
In drivers/clk/rockchip/clk.c and drivers/clk/rockchip/clk-cpu.c use the __clk_lookup.

> Heiko
>
> > Signed-off-by: Elaine Zhang <zhangqing@xxxxxxxxxxxxxx>
> > ---
> >   drivers/clk/clk.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> > index 3f588ed06ce3..600284fbb257 100644
> > --- a/drivers/clk/clk.c
> > +++ b/drivers/clk/clk.c
> > @@ -618,6 +618,7 @@ struct clk *__clk_lookup(const char *name)
> >   
> >   	return !core ? NULL : core->hw->clk;
> >   }
> > +EXPORT_SYMBOL_GPL(__clk_lookup);
> >   
> >   static void clk_core_get_boundaries(struct clk_core *core,
> >   				    unsigned long *min_rate,