Re: [PATCH v2 1/4] mm/hugetlb.c: make is_hugetlb_entry_hwpoisoned return bool

From: Anshuman Khandual
Date: Thu Jul 23 2020 - 00:47:34 EST




On 07/23/2020 08:52 AM, Baoquan He wrote:
> Just like its neighbour is_hugetlb_entry_migration() has done.
>
> Signed-off-by: Baoquan He <bhe@xxxxxxxxxx>
> Reviewed-by: Mike Kravetz <mike.kravetz@xxxxxxxxxx>
> Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>
> ---
> mm/hugetlb.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index f24acb3af741..3569e731e66b 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -3754,17 +3754,17 @@ bool is_hugetlb_entry_migration(pte_t pte)
> return false;
> }
>
> -static int is_hugetlb_entry_hwpoisoned(pte_t pte)
> +static bool is_hugetlb_entry_hwpoisoned(pte_t pte)
> {
> swp_entry_t swp;
>
> if (huge_pte_none(pte) || pte_present(pte))
> - return 0;
> + return false;
> swp = pte_to_swp_entry(pte);
> if (non_swap_entry(swp) && is_hwpoison_entry(swp))
> - return 1;
> + return true;
> else
> - return 0;
> + return false;
> }
>
> int copy_hugetlb_page_range(struct mm_struct *dst, struct mm_struct *src,
>

Reviewed-by: Anshuman Khandual <anshuman.khandual@xxxxxxx>