Re: [RFC] cpuidle : Add support for pseudo-cpuidle driver

From: Randy Dunlap
Date: Thu Jul 23 2020 - 02:25:11 EST


On 7/22/20 11:13 PM, Abhishek Goel wrote:
> diff --git a/drivers/cpuidle/Kconfig b/drivers/cpuidle/Kconfig
> index c0aeedd66f02..1d73153a0e35 100644
> --- a/drivers/cpuidle/Kconfig
> +++ b/drivers/cpuidle/Kconfig
> @@ -71,6 +71,15 @@ config HALTPOLL_CPUIDLE
> before halting in the guest (more efficient than polling in the
> host via halt_poll_ns for some scenarios).
>
> +config TEST_CPUIDLE
> + tristate "cpuidle test driver"
> + default m

No default, please.
We don't enable unneeded drivers for the fun of it.

> + help

Indent the following help text with one tab + 2 spaces.

> + This option enables a testing cpuidle driver, which allows to user

allows the user [or a user]

> + to define custom idle states with their respective latencies and residencies.
> + This is useful for testing the behaviour of governors on different
> + set of idle states.

sets

> +
> endif
>
> config ARCH_NEEDS_CPU_IDLE_COUPLED

thanks.
--
~Randy