Re: [PATCH] usb: gadget: net2280: fix memory leak on probe error handling paths

From: Evgeny Novikov
Date: Thu Jul 23 2020 - 04:52:11 EST


23.07.2020, 04:00, "Alan Stern" <stern@xxxxxxxxxxxxxxxxxxx>:
> On Wed, Jul 22, 2020 at 10:56:09PM +0300, Evgeny Novikov wrote:
>> ÂHi Alan,
>>
>> ÂI have neither an appropriate hardware nor an experience to deal with
>> Âissues that you mentioned. Our framework does not allow to detect them
>> Âas well at the moment. At last, it seems that rather many drivers can
>> Âsuffer from these issues. So, it would be much better if somebody else
>> Âwill suggest necessary fixes and test them carefully.
>
> Heh... Working from home, I no longer have access to the appropriate
> hardware either. But at least I do have the necessary experience. :-)
>
>> ÂBTW, you have already discussed the race within net2280_remove() with
>> Âmy colleague about 3 years ago. But you did not achieve a consensus at
>> Âthat time and no fixes were made after all.
>
> I don't recall that. Do you have a pointer to the email thread in the
> archives?
https://lkml.org/lkml/2017/8/16/345 - this is the top message of that thread.

Evgeny
>> ÂAnyway, one can consider both issues independently on the one fixed by
>> Âthe patch.
>
> Yes. I'll write and submit a series of patches.
>
> Alan Stern