Re: [PATCH] mips: traps, add __init to parity_protection_init

[Sergei Shtylyov]

Hello!

On 23.07.2020 12:42, Jiri Slaby wrote:

> It references __initdata and is called only from an __init function:
> trap_init. This avoids section mismatches (which I am seeing with gcc
> 10).
>
> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
> Cc: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>
> Cc: linux-mips@xxxxxxxxxxxxxxx
> ---
>   arch/mips/kernel/traps.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/kernel/traps.c b/arch/mips/kernel/traps.c
> index f655af68176c..702143ad7b47 100644
> --- a/arch/mips/kernel/traps.c
> +++ b/arch/mips/kernel/traps.c
> @@ -1680,7 +1680,7 @@ __setup("nol2par", nol2parity);
>    * Some MIPS CPUs can enable/disable for cache parity detection, but do
>    * it different ways.
>    */
> -static inline void parity_protection_init(void)
> +static inline __init void parity_protection_init(void)

   *inline* in a .c file? Perhaps gcc-10 has it out-of-line?

[...]

MBR, Sergei