Re: [PATCH v3] usb: dwc3: Add support for VBUS power control

[Mark Brown]

On Thu, Jul 23, 2020 at 09:56:14AM +0200, Vincent Whitchurch wrote:
> On Fri, Jun 19, 2020 at 04:25:12PM +0200, Mike Looijmans wrote:
> > +void dwc3_set_vbus(struct dwc3 *dwc, bool enable)
> > +{
> > +	int ret;
> > +
> > +	if (enable != dwc->vbus_reg_enabled) {
> > +		if (enable)
> > +			ret = regulator_enable(dwc->vbus_reg);
> > +		else
> > +			ret = regulator_disable(dwc->vbus_reg);
 
> dwc->vbus_reg is set to NULL when the regulator is not present.  These
> regulator_* functions expect a non-NULL pointer so a NULL check is
> required before calling them.

Does the device actually support running without power so that's a thing
that can happen?  _get_optional() should only ever be used for supplies
that may be physically absent.

Attachment: signature.asc
Description: PGP signature