Re: [char-misc-next 1/6] mei: hbm: use sizeof of variable instead of struct type

From: Greg Kroah-Hartman
Date: Thu Jul 23 2020 - 11:13:09 EST


On Thu, Jul 23, 2020 at 05:59:22PM +0300, Tomas Winkler wrote:
> There is a possibility of bug when variable type has changed but
> corresponding struct passed to the sizeof has not.
>
> Cc: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>
> Signed-off-by: Tomas Winkler <tomas.winkler@xxxxxxxxx>
> ---
> drivers/misc/mei/hbm.c | 74 ++++++++++++++++++------------------------
> 1 file changed, 32 insertions(+), 42 deletions(-)

This doesn't apply to my tree as I've applied Gustavo's patch. Should I
revert that first?

thanks,

greg k-h