Re: [PATCH] ceph: remove redundant initialization of variable mds

From: Jeff Layton
Date: Thu Jul 23 2020 - 13:24:14 EST


On Thu, 2020-07-23 at 16:22 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> The variable mds is being initialized with a value that is never read
> and it is being updated later with a new value. The initialization is
> redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> ---
> fs/ceph/debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ceph/debugfs.c b/fs/ceph/debugfs.c
> index 070ed8481340..48f5afb56c91 100644
> --- a/fs/ceph/debugfs.c
> +++ b/fs/ceph/debugfs.c
> @@ -272,7 +272,7 @@ static int mds_sessions_show(struct seq_file *s, void *ptr)
> struct ceph_mds_client *mdsc = fsc->mdsc;
> struct ceph_auth_client *ac = fsc->client->monc.auth;
> struct ceph_options *opt = fsc->client->options;
> - int mds = -1;
> + int mds;
>
> mutex_lock(&mdsc->mutex);
>

Thanks, merged into testing branch.
--
Jeff Layton <jlayton@xxxxxxxxxx>