Re: [char-misc-next 1/6] mei: hbm: use sizeof of variable instead of struct type

From: Greg Kroah-Hartman
Date: Thu Jul 23 2020 - 13:28:59 EST


On Thu, Jul 23, 2020 at 12:04:06PM -0500, Gustavo A. R. Silva wrote:
>
>
> On 7/23/20 10:13, Greg Kroah-Hartman wrote:
> > On Thu, Jul 23, 2020 at 05:59:22PM +0300, Tomas Winkler wrote:
> >> There is a possibility of bug when variable type has changed but
> >> corresponding struct passed to the sizeof has not.
> >>
> >> Cc: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>
> >> Signed-off-by: Tomas Winkler <tomas.winkler@xxxxxxxxx>
> >> ---
> >> drivers/misc/mei/hbm.c | 74 ++++++++++++++++++------------------------
> >> 1 file changed, 32 insertions(+), 42 deletions(-)
> >
> > This doesn't apply to my tree as I've applied Gustavo's patch. Should I
> > revert that first?
> >
>
> Yep; this series doesn't take into account my patch. I'm OK with
> reverting it, so we can apply this series.

Ok, will do, thanks!

greg k-h