Re: [PATCH net-next v3 1/2] hinic: add support to handle hw abnormal event

From: David Miller
Date: Thu Jul 23 2020 - 15:08:56 EST


From: Luo bin <luobin9@xxxxxxxxxx>
Date: Thu, 23 Jul 2020 22:40:37 +0800

> +static int hinic_fw_reporter_dump(struct devlink_health_reporter *reporter,
> + struct devlink_fmsg *fmsg, void *priv_ctx,
> + struct netlink_ext_ack *extack)
> +{
> + struct hinic_mgmt_watchdog_info *watchdog_info;
> + int err;
> +
> + if (priv_ctx) {
> + watchdog_info = priv_ctx;
> + err = mgmt_watchdog_report_show(fmsg, watchdog_info);
> + if (err)
> + return err;
> + }
> +
> + return 0;
> +}

This 'watchdog_info' variable is completely unnecessary, just pass
'priv_ctx' as-is into mgmt_watchdog_report_show().