Re: [PATCH] media: camss: fix memory leaks on error handling paths in probe
From: Markus Elfring
Date: Thu Jul 23 2020 - 15:51:37 EST
> camss_probe() does not free camss on error handling paths. The patch
> introduces an additional error label for this purpose.
* I suggest to use an imperative wording for the change description.
* Would you like to use also a jump target like the following
at the end of this function implementation?
+e_nomem:
+ ret = -ENOMEM;
+ goto err_free;
* Will the tag âFixesâ become helpful for the commit message?
> Besides, it
> removes call of v4l2_async_notifier_cleanup() from
> camss_of_parse_ports() since its caller, camss_probe(), cleans up all
> its resources itself.
I propose to offer such a change by a separate update step.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=d15be546031cf65a0fc34879beca02fd90fe7ac7#n138
Regards,
Markus