Re: [PATCH v2 1/2] i2c: add PEC error event

From: Wolfram Sang
Date: Thu Jul 23 2020 - 16:16:39 EST


On Fri, Jul 17, 2020 at 02:31:54PM +0530, Rayagonda Kokatanur wrote:
> Add new event I2C_SLAVE_PEC_ERR to list of slave events.
> This event will be used by slave bus driver to indicate
> PEC error to slave client or backend driver.
>
> Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@xxxxxxxxxxxx>

Definately needs documentation in Documentation/i2c/slave-interface.rst.

What is a backend supposed to do? Does 'value' have a meaning?

> ---
> include/linux/i2c.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/i2c.h b/include/linux/i2c.h
> index b8b8963f8bb9..e04acd04eb48 100644
> --- a/include/linux/i2c.h
> +++ b/include/linux/i2c.h
> @@ -370,6 +370,7 @@ enum i2c_slave_event {
> I2C_SLAVE_READ_PROCESSED,
> I2C_SLAVE_WRITE_RECEIVED,
> I2C_SLAVE_STOP,
> + I2C_SLAVE_PEC_ERR,
> };
>
> int i2c_slave_register(struct i2c_client *client, i2c_slave_cb_t slave_cb);
> --
> 2.17.1
>

Attachment: signature.asc
Description: PGP signature