Re: [PATCH] sched: Warn if garbage is passed to default_wake_function()

From: Peter Zijlstra
Date: Thu Jul 23 2020 - 16:21:12 EST


On Thu, Jul 23, 2020 at 09:10:42PM +0100, Chris Wilson wrote:
> Since the default_wake_function() passes its flags onto
> try_to_wake_up(), warn if those flags collide with internal values.
> Given that the supplied flags are garbage, no repair can be done but at
> least alert the user to the damage they are causing.
>
> In the belief that these errors should be picked up during testing, the
> warning is only compiled in under CONFIG_SCHED_DEBUG.
>
> Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Cc: Juri Lelli <juri.lelli@xxxxxxxxxx>
> Cc: Vincent Guittot <vincent.guittot@xxxxxxxxxx>

Thanks!