Re: [PATCH v2 1/2] dt-bindings: tas2562: Convert the tas2562 binding to yaml

[Dan Murphy]

Rob

On 7/23/20 3:18 PM, Rob Herring wrote:
> On Wed, Jul 22, 2020 at 10:47:05AM -0500, Dan Murphy wrote:
> > Convert the TAS2562 text file to yaml format.
> >
> > Signed-off-by: Dan Murphy <dmurphy@xxxxxx>
> > ---
> >
> > v2 - Updated the shutdown-gpio to shutdown-gpios and fixed licensing to be
> > GPL-2.0-only.
> >
> >   .../devicetree/bindings/sound/tas2562.yaml    | 69 +++++++++++++++++++
> >   1 file changed, 69 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/sound/tas2562.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/sound/tas2562.yaml b/Documentation/devicetree/bindings/sound/tas2562.yaml
> > new file mode 100644
> > index 000000000000..8d75a798740b
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/tas2562.yaml
> > @@ -0,0 +1,69 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +# Copyright (C) 2019 Texas Instruments Incorporated
> > +%YAML 1.2
> > +---
> > +$id: "http://devicetree.org/schemas/sound/tas2562.yaml#";
> > +$schema: "http://devicetree.org/meta-schemas/core.yaml#";
> > +
> > +title: Texas Instruments TAS2562 Smart PA
> > +
> > +maintainers:
> > +  - Dan Murphy <dmurphy@xxxxxx>
> > +
> > +description: |
> > +  The TAS2562 is a mono, digital input Class-D audio amplifier optimized for
> > +  efficiently driving high peak power into small loudspeakers.
> > +  Integrated speaker voltage and current sense provides for
> > +  real time monitoring of loudspeaker behavior.
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - ti,tas2562
> > +      - ti,tas2563
> > +
> > +  reg:
> > +    maxItems: 1
> > +    description: |
> > +       I2C address of the device can be one of these 0x4c, 0x4d, 0x4e or 0x4f
> > +
> > +  shut-down-gpios:
> > +    description: GPIO used to control the state of the device.
> > +    deprecated: true
> I think you should just remove this given it never worked with any
> released kernel. Otherwise,
>
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
I would but I came to know that there are customer DTs out there that 
have this property already in their product.

Dan