Re: [PATCH v4 00/12] ASoC: qcom: Add support for SC7180 lpass variant

[Rohit Kumar]

On 7/27/2020 3:20 PM, Rohit Kumar wrote:
> On 7/24/2020 4:52 PM, Srinivas Kandagatla wrote:
> > On 22/07/2020 11:31, Rohit kumar wrote:
> > > This patch chain add audio support for SC7180 soc by doing the required
> > > modification in existing common lpass-cpu/lpass-platform driver.
> > > This also fixes some concurrency issue.
> > >
> > > Changes since v3:
> > > ÂÂÂÂ- Fixed yaml documentation comments and make dt_binding_check 
> > > issues.
> > > ÂÂÂÂ- Moved general fixes out of sc7180 specific patches as 
> > > suggested by Srinivas.
> > > ÂÂÂÂ- Update clock-names to make it same as existing platforms.
> > >
> > > Ajit Pandey (4):
> > > ÂÂ ASoC: qcom: Add common array to initialize soc based core clocks
> > > ÂÂ ASoC: qcom: lpass-platform: Replace card->dev with component->dev
> > > ÂÂ include: dt-bindings: sound: Add sc7180-lpass bindings header
> > > ÂÂ ASoC: qcom: lpass-sc7180: Add platform driver for lpass audio
> > >
> > > Rohit kumar (8):
> > > ÂÂ ASoC: qcom: lpass-cpu: Move ahbix clk to platform specific function
> > > ÂÂ ASoC: qcom: lpass-platform: fix memory leak
> > > ÂÂ ASoC: qcom: lpass: Use regmap_field for i2sctl and dmactl registers
> > > ÂÂ ASoC: qcom: lpass-cpu: fix concurrency issue
> > > ÂÂ dt-bindings: sound: lpass-cpu: Add sc7180 lpass cpu node
> > > ÂÂ ASoC: qcom: lpass-cpu: Use platform_get_resource
> > > ÂÂ ASoC: qcom: lpass-platform: Use platform_get_irq
> > > ÂÂ dt-bindings: sound: lpass-cpu: Move to yaml format
> Thanks Srini for review and testing.
>
> Mark, I am planning to repost patch07 onwards to address comments by 
> Rob as
>
> there are no comments till patch06 and they are just fixes.

Hello Mark,

Are you planning to review/merge the changes till patch06. If not, I 
will resend those

patches along with comments addressed on patch07 onwards.

Thanks,

Rohit


> > Tested this on Dragon Board 410c!
> >
> > Tested-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
> >
> > --srini
> > > Â .../devicetree/bindings/sound/qcom,lpass-cpu.txtÂÂ |Â 79 --------
> > >  .../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 185 
> > > ++++++++++++++++++
> > > Â include/dt-bindings/sound/sc7180-lpass.hÂÂÂÂÂÂÂÂÂÂ |Â 10 +
> > > Â sound/soc/qcom/KconfigÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |ÂÂ 5 +
> > > Â sound/soc/qcom/MakefileÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |ÂÂ 2 +
> > > Â sound/soc/qcom/lpass-apq8016.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |Â 86 ++++++--
> > > Â sound/soc/qcom/lpass-cpu.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ | 204 
> > > ++++++++++---------
> > > Â sound/soc/qcom/lpass-ipq806x.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |Â 67 +++++++
> > > Â sound/soc/qcom/lpass-lpaif-reg.hÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ | 157 
> > > ++++++++-------
> > > Â sound/soc/qcom/lpass-platform.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ | 155 
> > > +++++++++++----
> > > Â sound/soc/qcom/lpass-sc7180.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ | 216 
> > > +++++++++++++++++++++
> > > Â sound/soc/qcom/lpass.hÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |Â 63 +++++-
> > > Â 12 files changed, 930 insertions(+), 299 deletions(-)
> > > Â delete mode 100644 
> > > Documentation/devicetree/bindings/sound/qcom,lpass-cpu.txt
> > > Â create mode 100644 
> > > Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
> > > Â create mode 100644 include/dt-bindings/sound/sc7180-lpass.h
> > > Â create mode 100644 sound/soc/qcom/lpass-sc7180.c
--
Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member
of the Code Aurora Forum, hosted by the Linux Foundation.