Re: [PATCH v4 69/78] drm/vc4: hdmi: Remove register dumps in enable

[Dave Stevenson]

Hi Maxime

On Wed, 8 Jul 2020 at 18:44, Maxime Ripard <maxime@xxxxxxxxxx> wrote:
>
> The current code has some logic, disabled by default, to dump the register
> setup in the HDMI controller.
>
> However, since we're going to split those functions in multiple, shorter,
> functions that only make sense where they are called in sequence, keeping
> the register dump makes little sense.
>
> Signed-off-by: Maxime Ripard <maxime@xxxxxxxxxx>

Reviewed-by: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx>

> ---
>  drivers/gpu/drm/vc4/vc4_hdmi.c | 17 -----------------
>  1 file changed, 17 deletions(-)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
> index 0a9a323e03d8..4058985940e6 100644
> --- a/drivers/gpu/drm/vc4/vc4_hdmi.c
> +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
> @@ -430,7 +430,6 @@ static void vc4_hdmi_encoder_enable(struct drm_encoder *encoder)
>         struct drm_display_mode *mode = &encoder->crtc->state->adjusted_mode;
>         struct vc4_hdmi *vc4_hdmi = encoder_to_vc4_hdmi(encoder);
>         struct vc4_hdmi_encoder *vc4_encoder = to_vc4_hdmi_encoder(encoder);
> -       bool debug_dump_regs = false;
>         unsigned long pixel_rate, hsm_rate;
>         int ret;
>
> @@ -489,14 +488,6 @@ static void vc4_hdmi_encoder_enable(struct drm_encoder *encoder)
>         if (vc4_hdmi->variant->phy_init)
>                 vc4_hdmi->variant->phy_init(vc4_hdmi, mode);
>
> -       if (debug_dump_regs) {
> -               struct drm_printer p = drm_info_printer(&vc4_hdmi->pdev->dev);
> -
> -               dev_info(&vc4_hdmi->pdev->dev, "HDMI regs before:\n");
> -               drm_print_regset32(&p, &vc4_hdmi->hdmi_regset);
> -               drm_print_regset32(&p, &vc4_hdmi->hd_regset);
> -       }
> -
>         HDMI_WRITE(HDMI_VID_CTL, 0);
>
>         HDMI_WRITE(HDMI_SCHEDULER_CONTROL,
> @@ -522,14 +513,6 @@ static void vc4_hdmi_encoder_enable(struct drm_encoder *encoder)
>
>         HDMI_WRITE(HDMI_FIFO_CTL, VC4_HDMI_FIFO_CTL_MASTER_SLAVE_N);
>
> -       if (debug_dump_regs) {
> -               struct drm_printer p = drm_info_printer(&vc4_hdmi->pdev->dev);
> -
> -               dev_info(&vc4_hdmi->pdev->dev, "HDMI regs after:\n");
> -               drm_print_regset32(&p, &vc4_hdmi->hdmi_regset);
> -               drm_print_regset32(&p, &vc4_hdmi->hd_regset);
> -       }
> -
>         HDMI_WRITE(HDMI_VID_CTL,
>                    HDMI_READ(HDMI_VID_CTL) |
>                    VC4_HD_VID_CTL_ENABLE |
> --
> git-series 0.9.1