Re: [PATCH v4 1/4] power: supply: core: add quick charge type property

[Greg KH]

On Sun, Aug 02, 2020 at 04:28:25PM +0200, Pavel Machek wrote:
> On Sun 2020-08-02 14:37:42, Greg KH wrote:
> > On Sun, Aug 02, 2020 at 02:00:15PM +0200, Pavel Machek wrote:
> > > On Mon 2020-07-20 13:47:14, Qiwu Huang wrote:
> > > > From: Qiwu Huang <huangqiwu@xxxxxxxxxx>
> > > > 
> > > > Reports the kind of quick charge type based on
> > > > different adapter power.
> > > > 
> > > > Signed-off-by: Qiwu Huang <huangqiwu@xxxxxxxxxx>
> > > > ---
> > > >  Documentation/ABI/testing/sysfs-class-power | 21 +++++++++++++++++++++
> > > >  drivers/power/supply/power_supply_sysfs.c   |  1 +
> > > >  include/linux/power_supply.h                | 10 ++++++++++
> > > >  3 files changed, 32 insertions(+)
> > > > 
> > > > diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power
> > > > index 216d61a22f1e..dd3773dcf16a 100644
> > > > --- a/Documentation/ABI/testing/sysfs-class-power
> > > > +++ b/Documentation/ABI/testing/sysfs-class-power
> > > > @@ -708,3 +708,24 @@ Description:
> > > >  
> > > >  		Access: Read
> > > >  		Valid values: 1-31
> > > > +
> > > > +What:		/sys/class/power_supply/<supply_name>/quick_charge_type
> > > > +Date:		Jul 2020
> > > > +Contact:	Fei Jiang <jiangfei1@xxxxxxxxxx>
> > > > +		Description:
> > > > +		Reports the kind of quick charge type based on different adapter power.
> > > > +		Different quick charge type represent different charging power.
> > > > +		QUICK_CHARGE_NORMAL : Charging Power <= 10W
> > > > +		QUICK_CHARGE_FAST : 10W < Charging Power <= 20W
> > > > +		QUICK_CHARGE_FLASH : 20W < Charging Power <= 30W
> > > > +		QUICK_CHARGE_TURBE : 30W < Charging Power <= 50W
> > > > +		QUICK_CHARGE_SUPER : Charging Power > 50W
> > > > +
> > > > +		Access: Read-Only
> > > > +		Valid values:
> > > > +			0: QUICK_CHARGE_NORMAL,
> > > > +			1: QUICK_CHARGE_FAST,
> > > > +			2: QUICK_CHARGE_FLASH,
> > > > +			3: QUICK_CHARGE_TURBE,
> > > > +			4: QUICK_CHARGE_SUPER.
> > > 
> > > NAK.
> > > 
> > > Just expose value in watts or something... People are talking about > 100W charging, no
> > > need to go with fast/turbe/super/hyper/nonsense.
> > > 
> > > BTW fast charge is already "well defined", and what you call Normal is usually fast charge.
> > 
> > I think these names come from the Qi charging spec, right?  So lets use
> > what is given to us.
> 
> There are other standards, and this should better be generic.

What standard?  Why not go with this one, it's documented and out there
and being used.

> Simply expose value in watts.

What if you do not know the watts, you just know these ranges.

thanks,

greg k-h