Re: [PATCH] ARM: s3c24xx: demote kerneldoc comment

[Randy Dunlap]

On 8/2/20 1:36 PM, Krzysztof Kozlowski wrote:
> Remove kerneldoc annotation to fix warning:
> 
>     arch/arm/mach-s3c24xx/mach-h1940.c:185: warning:
>         cannot understand function prototype: 'struct s3c2410fb_display h1940_lcd __initdata = '
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> ---
>  arch/arm/mach-s3c24xx/mach-h1940.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-s3c24xx/mach-h1940.c b/arch/arm/mach-s3c24xx/mach-h1940.c
> index 89528bea89f1..c09f61d35d57 100644
> --- a/arch/arm/mach-s3c24xx/mach-h1940.c
> +++ b/arch/arm/mach-s3c24xx/mach-h1940.c
> @@ -179,9 +179,9 @@ static struct s3c2410_ts_mach_info h1940_ts_cfg __initdata = {
>  		.cfg_gpio = s3c24xx_ts_cfg_gpio,
>  };
>  
> -/**
> +/*
>   * Set lcd on or off
> - **/
> + */

Yes, that's not kernel-doc notation, so demote it.
Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>


OTOH, we could also add "__initdata" to something that can be
handled by scripts/kernel-doc if it's needed, but it doesn't seem to
be needed just yet.

>  static struct s3c2410fb_display h1940_lcd __initdata = {
>  	.lcdcon5=	S3C2410_LCDCON5_FRM565 | \
>  			S3C2410_LCDCON5_INVVLINE | \
> 

thanks.
-- 
~Randy