Re: [PATCH] vop: Add missing __iomem annotation in vop_dc_to_vdev()

From: Dixit, Ashutosh
Date: Mon Aug 03 2020 - 00:27:21 EST


On Sun, 02 Aug 2020 21:24:01 -0700, Greg Kroah-Hartman wrote:
>
> On Sun, Aug 02, 2020 at 04:28:12PM -0700, Ashutosh Dixit wrote:
> > Fix the following sparse warnings in drivers/misc/mic/vop//vop_main.c:
> >
> > 551:58: warning: incorrect type in argument 1 (different address spaces)
> > 551:58: expected void const volatile [noderef] __iomem *addr
> > 551:58: got restricted __le64 *
> > 560:49: warning: incorrect type in argument 1 (different address spaces)
> > 560:49: expected struct mic_device_ctrl *dc
> > 560:49: got struct mic_device_ctrl [noderef] __iomem *dc
> > 579:49: warning: incorrect type in argument 1 (different address spaces)
> > 579:49: expected struct mic_device_ctrl *dc
> > 579:49: got struct mic_device_ctrl [noderef] __iomem *dc
> >
> > Cc: Michael S. Tsirkin <mst@xxxxxxxxxx>
> > Cc: Sudeep Dutt <sudeep.dutt@xxxxxxxxx>
> > Cc: Arnd Bergmann <arnd@xxxxxxxx>
> > Cc: Vincent Whitchurch <vincent.whitchurch@xxxxxxxx>
> > Cc: stable <stable@xxxxxxxxxxxxxxx>
>
> Why is this a stable thing? It doesn't fix a real bug, and sparse
> warnings are not needed for stable trees, unless this is the last sparse
> warning there.

It is the last sparse warning. Sorry I wasn't sure about stable so I
thought might as well. Please ignore if it's not required. Thanks.