Re: [PATCH] Module argument to control whether intel-spi-pci attempts to turn the SPI flash chip writeable

From: Richard Hughes
Date: Mon Aug 03 2020 - 06:18:27 EST


On Mon, 3 Aug 2020 at 10:57, Mika Westerberg
<mika.westerberg@xxxxxxxxxxxxxxx> wrote:
> I think instead of this we should simply make it so that the driver
> never tries to make the chip writable.

I think this is a good idea, but I wasn't sure if it was an acceptable
behaviour change. Should the driver still try to set BCR_WPD when
writing an image (i.e. defer the setting of write enable until later),
or just not set the BCR register at all? I think your last comment was
the latter, but wanted to check.

Richard.