Re: [PATCH] vgacon: fix out of bounds write to the scrollback buffer

From: Bartlomiej Zolnierkiewicz
Date: Mon Aug 03 2020 - 07:07:26 EST



On 8/3/20 11:47 AM, Greg KH wrote:
> On Mon, Aug 03, 2020 at 10:45:07AM +0200, Daniel Vetter wrote:
>> On Mon, Aug 3, 2020 at 10:26 AM Greg KH <greg@xxxxxxxxx> wrote:
>>>
>>> On Mon, Aug 03, 2020 at 10:08:43AM +0200, Jiri Slaby wrote:
>>>> Hi,
>>>>
>>>> On 31. 07. 20, 7:22, 张云海 wrote:
>>>>> Remove whitespace at EOL
>>>>
>>>> I am fine with the patch. However it should be sent properly (inline
>>>> mail, having a PATCH subject etc. -- see
>>>> Documentation/process/submitting-patches.rst). git send-email after git
>>>> format-patch handles most of it.
>>>>
>>>> There is also question who is willing to take it?
>>>>
>>>> Bart? Greg? Should we route it via akpm, or will you Linus directly? (I
>>>> can sign off and resend the patch which was attached to the mail I am
>>>> replying to too, if need be.)
>>>
>>> I can take it, if Bart can't, just let me know.
>>
>> Yeah vt stuff and console drivers != fbcon go through Greg's tree past
>> few years ...
>>
>> Greg, should we maybe add a MAINTAINERS entry that matches on all
>> things console? With tty/vt you definitely have the other side of that
>> coin already :-)
>
> Sure, that would be good as things do fall through the cracks at times.

Since taking over fbdev in 2017 I've tried to act as the last resort
Maintainer for console stuff (AFAIK there are no "lost" patches) but
it really deserves its own entry.

Also most console patches make it through you nowadays anyway:

$ git log --pretty=fuller --since=2017 drivers/video/console/|grep "Commit\:"|sort|uniq -cd
2 Commit: Arnd Bergmann <arnd@xxxxxxxx>
11 Commit: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>
2 Commit: Daniel Vetter <daniel.vetter@xxxxxxxx>
3 Commit: Dave Airlie <airlied@xxxxxxxxxx>
12 Commit: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
7 Commit: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
2 Commit: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>

> If you write the patch, I'll merge it :)
ACK from me. :)

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics