Re: [PATCH 03/10] ASoC: audio-graph: Support Codec with multiple endpoints

[Sameer Pujar]

On 7/20/2020 10:43 AM, Kuninori Morimoto wrote:
> External email: Use caution opening links or attachments
>
>
> Hi Sameer
>
> > > > diff --git a/sound/soc/generic/audio-graph-card.c b/sound/soc/generic/audio-graph-card.c
> > > > index 1e20562..b1903f9 100644
> > > > --- a/sound/soc/generic/audio-graph-card.c
> > > > +++ b/sound/soc/generic/audio-graph-card.c
> > > > @@ -201,8 +201,7 @@ static void graph_parse_mclk_fs(struct device_node *top,
> > > >    static int graph_dai_link_of_dpcm(struct asoc_simple_priv *priv,
> > > >                                   struct device_node *cpu_ep,
> > > >                                   struct device_node *codec_ep,
> > > > -                               struct link_info *li,
> > > > -                               int dup_codec)
> > > > +                               struct link_info *li)
> > > This patch breaks DPCM connection which is used for MIXer
> > Could you please elaborate a bit more as to what is broken with this?
> > The problem I am trying to solve here is to have multiple endpoints
> > for Codec port.
> For example MIXer, it is like below.
> If you removes "dup_codec", it breaks MIXer and/or TDM split mode.
>
>          CPU0  ---+---- DAI
>                   |
>          CPU1  ---+
>
>          cpu {
>                  ports {
>                          port@0 {
>                                  cpu_0: endpoint {
>                                          remote-endpoint = <&codec_0>;
>                                  };
>                          };
>                          port@1 {
>                                  cpu_1: endpoint {
>                                          remote-endpoint = <&codec_1>;
>                                  };
>                          };
>                  };
>          };
>
>          codec {
>                  port {
>                          codec_0: endpoint {
>                                  remote-endpoint = <&cpu_0>;
>                          };
>                          codec_1: endpoint {
>                                  remote-endpoint = <&cpu_1>;
>                          };
>                  }
>          };

Thanks Kuninori for explaining above and for giving a background in an 
'off-list' thread. I will re-work on the patch by limiting the changes 
to specific flag so that it does not affect any other user.

> Thank you for your help !!
>
> Best regards
> ---
> Kuninori Morimoto