Re: Re: Re: [PATCH v2 1/5] drm/mediatek: config component output by device node port
From: Chun-Kuang Hu
Date: Mon Aug 03 2020 - 12:27:19 EST
Hi, Frank:
Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx> 於 2020年8月3日 週一 下午6:43寫道:
>
> Hi
> > Gesendet: Montag, 03. August 2020 um 01:47 Uhr
> > Von: "Chun-Kuang Hu" <chunkuang.hu@xxxxxxxxxx>
>
> > Now I just care about the bls to dpi. So in mediatek,disp.txt, you
> > just need to add a Optional properties - port (input and output), and
> > modify mediatek,dpi.txt for its input port.
>
> you mean something like this is enough:
>
> Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
>
> argument, see Documentation/devicetree/bindings/iommu/mediatek,iommu.txt
> for details.
>
> +Optional properties:
> +- port (input and output) see ../../media/video-interfaces.txt
> +
> Examples:
>
> Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt:
>
> Optional properties:
> - pinctrl-names: Contain "default" and "sleep".
> +- port: Input port node with endpoint definition, this can be connected to <chipid>-disp-pwm
>
> Example:
>
> should i link to pwm/pwm-mtk-disp.txt in doc?
>
> regards Frank
Yes, this is what I mean, but I think it need not output to pmw.
But now I have a solution that you need not to modify binding document.
Because now mt7623 has a different routing than mt2701, and this
patch's approach is to use different port setting in each device tree.
My solution is that these two SoC has different compatible string:
"mediatek,mt7623-mmsys" and "mediatek,mt2701-mmsys". For now,
"mediatek,mt2701-mmsys" has its data as
static const struct mtk_mmsys_driver_data mt2701_mmsys_driver_data = {
.main_path = mt2701_mtk_ddp_main,
.main_len = ARRAY_SIZE(mt2701_mtk_ddp_main),
.ext_path = mt2701_mtk_ddp_ext,
.ext_len = ARRAY_SIZE(mt2701_mtk_ddp_ext),
.shadow_register = true,
};
I think you could create a data for "mediatek,mt7623-mmsys" which has
a different routing.
Regards,
Chun-Kuang.