Re: [PATCH v2 2/2] leds: pca955x: Add an IBM software implementation of the PCA9552 chip

[Andy Shevchenko]

On Mon, Aug 3, 2020 at 5:51 PM Eddie James <eajames@xxxxxxxxxxxxx> wrote:
>
> IBM created an implementation of the PCA9552 on a PIC16F
> microcontroller. The I2C device addresses are different from the
> hardware PCA9552, so add a new compatible string and associated
> platform data to be able to probe this device.

...

>         pca9550,
>         pca9551,
>         pca9552,
> +       ibm_pca9552,
>         pca9553,

I would rather not mix like this, but use alpha order, for example.
It's better to read and see which devices are supported by vendor.

...

>         },

> +       [ibm_pca9552] = {

> +       },
>         [pca9553] = {

Ditto.

...

>         { "pca9550", pca9550 },
>         { "pca9551", pca9551 },
>         { "pca9552", pca9552 },
> +       { "ibm-pca9552", ibm_pca9552 },
>         { "pca9553", pca9553 },

Ditto.

...

>         { .compatible = "nxp,pca9550", .data = (void *)pca9550 },
>         { .compatible = "nxp,pca9551", .data = (void *)pca9551 },
>         { .compatible = "nxp,pca9552", .data = (void *)pca9552 },
> +       { .compatible = "ibm,pca9552", .data = (void *)ibm_pca9552 },
>         { .compatible = "nxp,pca9553", .data = (void *)pca9553 },

Ditto.

-- 
With Best Regards,
Andy Shevchenko