Re: [Linux-kernel-mentees] [PATCH net] openvswitch: Prevent kernel-infoleak in ovs_ct_put_key()

[Peilin Ye]

On Mon, Aug 03, 2020 at 03:10:38PM -0700, David Miller wrote:
> From: Peilin Ye <yepeilin.cs@xxxxxxxxx>
> Date: Fri, 31 Jul 2020 00:48:38 -0400
> 
> > ovs_ct_put_key() is potentially copying uninitialized kernel stack memory
> > into socket buffers, since the compiler may leave a 3-byte hole at the end
> > of `struct ovs_key_ct_tuple_ipv4` and `struct ovs_key_ct_tuple_ipv6`. Fix
> > it by initializing `orig` with memset().
> > 
> > Cc: stable@xxxxxxxxxxxxxxx
> 
> Please don't CC: stable for networking fixes.

Sorry, I didn't know about that.

> > Fixes: 9dd7f8907c37 ("openvswitch: Add original direction conntrack tuple to sw_flow_key.")
> > Suggested-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> > Signed-off-by: Peilin Ye <yepeilin.cs@xxxxxxxxx>
> 
> Applied and queued up for -stable, thank you.

Thank you for reviewing the patch!

Peilin Ye