Re: [PATCH v8 06/10] media: tegra-video: Add support for external sensor capture

[Dmitry Osipenko]

03.08.2020 18:42, Sowjanya Komatineni пишет:
> This patch adds support to capture from the external sensor
> based on device graph in the device tree.
> 
> Driver walks through the device graph to create media links
> between the entities and registers and unregisters video devices
> when the corresponding sub-devices are bound and unbound.
> 
> Channel formats are enumerated based on available formats from
> the sensor and the corresponding matched formats from the Tegra
> supported video formats list.
> 
> Each Tegra CSI instance can be configured as 4-lane or 2-lane
> based on supported lane configuration from the sensor through
> the device tree.
> 
> Currently this driver supports V4L2 video node centric only.
> 
> Signed-off-by: Sowjanya Komatineni <skomatineni@xxxxxxxxxx>
> ---
>  drivers/staging/media/tegra-video/Kconfig    |   1 +
>  drivers/staging/media/tegra-video/TODO       |   4 -
>  drivers/staging/media/tegra-video/csi.c      | 139 +++++-
>  drivers/staging/media/tegra-video/csi.h      |   1 +
>  drivers/staging/media/tegra-video/tegra210.c |   2 +-
>  drivers/staging/media/tegra-video/vi.c       | 692 +++++++++++++++++++++++++--
>  drivers/staging/media/tegra-video/vi.h       |  25 +-
>  7 files changed, 800 insertions(+), 64 deletions(-)

This and the rest of the patches look sane to me, thanks.

Reviewed-by: Dmitry Osipenko <digetx@xxxxxxxxx>