Re: [PATCH v2 11/24] virtio_input: correct tags for config space fields

From: Gerd Hoffmann
Date: Tue Aug 04 2020 - 02:01:54 EST


On Mon, Aug 03, 2020 at 04:59:23PM -0400, Michael S. Tsirkin wrote:
> Since this is a modern-only device,
> tag config space fields as having little endian-ness.
>
> Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
> ---
> include/uapi/linux/virtio_input.h | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/include/uapi/linux/virtio_input.h b/include/uapi/linux/virtio_input.h
> index a7fe5c8fb135..52084b1fb965 100644
> --- a/include/uapi/linux/virtio_input.h
> +++ b/include/uapi/linux/virtio_input.h
> @@ -40,18 +40,18 @@ enum virtio_input_config_select {
> };
>
> struct virtio_input_absinfo {
> - __u32 min;
> - __u32 max;
> - __u32 fuzz;
> - __u32 flat;
> - __u32 res;
> + __le32 min;
> + __le32 max;
> + __le32 fuzz;
> + __le32 flat;
> + __le32 res;
> };
>
> struct virtio_input_devids {
> - __u16 bustype;
> - __u16 vendor;
> - __u16 product;
> - __u16 version;
> + __le16 bustype;
> + __le16 vendor;
> + __le16 product;
> + __le16 version;
> };
>
> struct virtio_input_config {
> --
> MST

Reviewed-by: Gerd Hoffmann <kraxel@xxxxxxxxxx>