Re: [net-next v2] seg6: using DSCP of inner IPv4 packets

[Ahmed Abdelsalam]

The problem was the declaration of tos.
Fixed and new patch is sent.

On 03/08/2020 21:48, Jakub Kicinski wrote:
> On Mon,  3 Aug 2020 18:14:17 +0000 Ahmed Abdelsalam wrote:
> > This patch allows copying the DSCP from inner IPv4 header to the
> > outer IPv6 header, when doing SRv6 Encapsulation.
> >
> > This allows forwarding packet across the SRv6 fabric based on their
> > original traffic class.
> >
> > Signed-off-by: Ahmed Abdelsalam <ahabdels@xxxxxxxxx>
>
> Please make sure it builds cleanly with W=1 C=1:
>
> net/ipv6/seg6_iptunnel.c:131:21: warning: incorrect type in assignment (different base types)
> net/ipv6/seg6_iptunnel.c:131:21:    expected restricted __be32 [usertype] tos
> net/ipv6/seg6_iptunnel.c:131:21:    got unsigned char
> net/ipv6/seg6_iptunnel.c:133:21: warning: incorrect type in assignment (different base types)
> net/ipv6/seg6_iptunnel.c:133:21:    expected restricted __be32 [usertype] tos
> net/ipv6/seg6_iptunnel.c:133:21:    got unsigned char [usertype] tos
> net/ipv6/seg6_iptunnel.c:144:27: warning: incorrect type in argument 2 (different base types)
> net/ipv6/seg6_iptunnel.c:144:27:    expected unsigned int tclass
> net/ipv6/seg6_iptunnel.c:144:27:    got restricted __be32 [usertype] tos