RE: PATCH: rtsx_pci driver - don't disable the rts5229 card reader on Intel NUC boxes

[吳昊澄 Ricky]

> -----Original Message-----
> From: gregkh@xxxxxxxxxxxxxxxxxxx [mailto:gregkh@xxxxxxxxxxxxxxxxxxx]
> Sent: Tuesday, August 04, 2020 3:49 PM
> To: 吳昊澄 Ricky
> Cc: Chris Clayton; LKML; rdunlap@xxxxxxxxxxxxx; philquadra@xxxxxxxxx; Arnd
> Bergmann
> Subject: Re: PATCH: rtsx_pci driver - don't disable the rts5229 card reader on
> Intel NUC boxes
> 
> On Tue, Aug 04, 2020 at 02:44:41AM +0000, 吳昊澄 Ricky wrote:
> > Hi Chris,
> >
> > rtsx_pci_write_register(pcr, FPDTL, OC_POWER_DOWN, OC_POWER_DOWN);
> > This register operation saved power under 1mA, so if do not care the 1mA
> power we can have a patch to remove it, make compatible with NUC6
> > We tested others our card reader that remove it, we did not see any side effect
> >
> > Hi Greg k-h,
> >
> > Do you have any comments?
> 
> comments on what?  I don't know what you are responding to here, sorry.
> 
Can we have a patch to kernel for NUC6? It may cause more power(1mA) but it will have more compatibility

> greg k-h
> 
> ------Please consider the environment before printing this e-mail.