Re: [PATCH 2/2] speakup: only build serialio when ISA is enabled

[Greg KH]

On Tue, Aug 04, 2020 at 01:13:32PM +0200, Samuel Thibault wrote:
> Drivers using serialio are already made available in Kconfig only under
> the ISA condition.
> 
> This solves warnings in inb/outb macros on platform that do not have 
> support for ISA.
> 
> Signed-off-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
> 
> Index: linux-2.6/drivers/accessibility/speakup/Makefile
> ===================================================================
> --- linux-2.6.orig/drivers/accessibility/speakup/Makefile
> +++ linux-2.6/drivers/accessibility/speakup/Makefile
> @@ -16,6 +16,7 @@ obj-$(CONFIG_SPEAKUP_SYNTH_TXPRT) += spe
>  obj-$(CONFIG_SPEAKUP_SYNTH_DUMMY) += speakup_dummy.o
>  
>  obj-$(CONFIG_SPEAKUP) += speakup.o
> +obj-$(CONFIG_ISA) += serialio.o
>  speakup-y := \
>  	buffers.o \
>  	devsynth.o \
> @@ -25,7 +26,6 @@ speakup-y := \
>  	keyhelp.o \
>  	kobjects.o \
>  	selection.o \
> -	serialio.o \
>  	spk_ttyio.o \
>  	synth.o \
>  	thread.o \

Nice, this should fix the riscv build issues.

I'll go merge this now, and hold on to the first patch until this round
gets merged with Linus.

thanks,

greg k-h