Re: [PATCH] lib: kunit: add test_min_heap test conversion to KUnit

From: peterz
Date: Tue Aug 04 2020 - 09:25:46 EST


On Wed, Jul 29, 2020 at 06:57:17PM -0300, Vitor Massaru Iha wrote:

> The results can be seen this way:
>
> This is an excerpt from the test.log with the result in TAP format:
> [snip]
> ok 5 - example
> # Subtest: min-heap
> 1..6
> ok 1 - test_heapify_all_true
> ok 2 - test_heapify_all_false
> ok 3 - test_heap_push_true
> ok 4 - test_heap_push_false
> ok 5 - test_heap_pop_push_true
> ok 6 - test_heap_pop_push_false
> [snip]
>
> And this from kunit-tool:
> [snip]
> [18:43:32] ============================================================
> [18:43:32] ======== [PASSED] min-heap ========
> [18:43:32] [PASSED] test_heapify_all_true
> [18:43:32] [PASSED] test_heapify_all_false
> [18:43:32] [PASSED] test_heap_push_true
> [18:43:32] [PASSED] test_heap_push_false
> [18:43:32] [PASSED] test_heap_pop_push_true
> [18:43:32] [PASSED] test_heap_pop_push_false
> [18:43:32] ============================================================
> [18:43:32] Testing complete. 20 tests run. 0 failed. 0 crashed.
> [18:43:32] Elapsed time: 9.758s total, 0.001s configuring, 6.012s
> building, 0.000s running
> [snip]

I don't care or care to use either; what does dmesg do? It used to be
that just building the self-tests was sufficient and any error would
show in dmesg when you boot the machine.

But if I now have to use some damn tool, this is a regression.