Re: [PATCH v2 3/3] ext4: add needed paramter to ext4_mb_discard_preallocations trace

[Andreas Dilger]

On Aug 4, 2020, at 7:02 PM, brookxu <brookxu.cn@xxxxxxxxx> wrote:
> 
> Add the needed value to ext4_mb_discard_preallocations trace, so
> we can more easily observe the requested number of trim.
> 
> Signed-off-by: Chunguang Xu <brookxu@xxxxxxxxxxx>

IMHO, this should be part of the previous patch that is changing the
API for ext4_discard_preallocations().

Cheers, Andreas

> ---
>  include/trace/events/ext4.h | 14 ++++++++------
>  1 file changed, 8 insertions(+), 6 deletions(-)
> 
> diff --git a/include/trace/events/ext4.h b/include/trace/events/ext4.h
> index cc41d69..61736d8 100644
> --- a/include/trace/events/ext4.h
> +++ b/include/trace/events/ext4.h
> @@ -746,24 +746,26 @@
>  );
> 
>  TRACE_EVENT(ext4_discard_preallocations,
> -    TP_PROTO(struct inode *inode),
> +    TP_PROTO(struct inode *inode, unsigned int needed),
> 
> -    TP_ARGS(inode),
> +    TP_ARGS(inode, needed),
> 
>      TP_STRUCT__entry(
> -        __field(    dev_t,    dev            )
> -        __field(    ino_t,    ino            )
> +        __field(    dev_t,        dev        )
> +        __field(    ino_t,        ino        )
> +        __field(    unsigned int,    needed        )
> 
>      ),
> 
>      TP_fast_assign(
>          __entry->dev    = inode->i_sb->s_dev;
>          __entry->ino    = inode->i_ino;
> +        __entry->needed    = needed;
>      ),
> 
> -    TP_printk("dev %d,%d ino %lu",
> +    TP_printk("dev %d,%d ino %lu needed %u",
>            MAJOR(__entry->dev), MINOR(__entry->dev),
> -          (unsigned long) __entry->ino)
> +          (unsigned long) __entry->ino, __entry->needed)
>  );
> 
>  TRACE_EVENT(ext4_mb_discard_preallocations,
> 
> --
> 1.8.3.1
> 


Cheers, Andreas

Attachment: signature.asc
Description: Message signed with OpenPGP