Re: [PATCH 1/1] arm64: kexec: no need to do irq_chip->irq_mask if it already masked

From: Sudeep Holla
Date: Wed Aug 05 2020 - 04:48:14 EST


On Wed, Aug 05, 2020 at 06:31:20AM +0000, Jason Liu wrote:
> >
> > Indeed, the runtime PM ops in that driver looks dodgy. Any calls to mask_irq
> > from drivers or anywhere with irqchip suspended with just blows up the
> > system.
>
> If you look at the chip->irq_mask implementation on different platforms, almost
> all with directly access the register of the irqchip including irqsteer.
> There are fine due to driver will use the common mask_irq API.
>

That still doesn't explain how you can prevent system from blowing up if
chip->irq_mask gets called with irqchip suspended ?

--
Regards,
Sudeep