Re: [PATCH 08/18] fsinfo: Allow mount topology and propagation info to be retrieved [ver #21]

From: David Howells
Date: Wed Aug 05 2020 - 12:23:35 EST


Miklos Szeredi <miklos@xxxxxxxxxx> wrote:

> > + __u32 shared_group_id; /* Shared: mount group ID */
> > + __u32 dependent_source_id; /* Dependent: source mount group ID */
> > + __u32 dependent_clone_of_id; /* Dependent: ID of mount this was cloned from */
>
> Another set of ID's that are currently 32bit *internally* but that doesn't
> mean they will always be 32 bit.
>
> And that last one (apart from "slave" being obfuscated)

I had "slave" in there. It got objected to. See
Documentation/process/coding-style.rst section 4.

> is simply incorrect. It has nothing to do with cloning. It's the "ID of
> the closest peer group in the propagation chain that has a representative
> mount in the current root".

You appear to be in disagreement with others that I've asked.

David