Re: [PATCH 15/18] fsinfo: Add an attribute that lists all the visible mounts in a namespace [ver #21]

From: David Howells
Date: Wed Aug 05 2020 - 15:56:30 EST


Miklos Szeredi <miklos@xxxxxxxxxx> wrote:

> > where each element contains a once-in-a-system-lifetime unique ID, the
> > mount ID (which may get reused), the parent mount ID and sums of the
> > notification/change counters for the mount and its superblock.
>
> The change counters are currently conditional on CONFIG_MOUNT_NOTIFICATIONS.
> Is this is intentional?

Yeah - the counters aren't driven unless CONFIG_MOUNT_NOTIFICATIONS=y.

I could perhaps make it so they're driven in both cases, but driving the
in-subtree counter is somewhat tied up in the notification posting.

This is something that can be fixed after this patchset is taken - if it is
taken since that doesn't change the UAPI.

David