Re: [PATCH] MAINTAINERS: update phylink/sfp keyword matching

[Andrew Lunn]

On Wed, Aug 05, 2020 at 11:47:38AM -0700, Joe Perches wrote:
> On Wed, 2020-08-05 at 19:22 +0100, Russell King - ARM Linux admin wrote:
> > On Wed, Aug 05, 2020 at 11:11:28AM -0700, Linus Torvalds wrote:
> > > On Wed, Aug 5, 2020 at 7:34 AM Russell King <rmk+kernel@xxxxxxxxxxxxxxx> wrote:
> > > > Is this something you're willing to merge directly please?
> > > 
> > > Done.
> > > 
> > > That said:
> > > 
> > > > -K:     phylink
> > > > +K:     phylink\.h|struct\s+phylink|\.phylink|>phylink_|phylink_(autoneg|clear|connect|create|destroy|disconnect|ethtool|helper|mac|mii|of|set|start|stop|test|validate)
> > > 
> > > That's a very awkward pattern. I wonder if there could be better ways
> > > to express this (ie "only apply this pattern to these files" kind of
> > > thing)
> > 
> > Yes, it's extremely awkward - I spent much of the morning with perl
> > testing it out on the drivers/ subtree.
> 
> There are a lot of phylink_<foo> in the kernel.
> Are those really the only uses you want to watch?

Hi Joe

I think Rusells intention here is to match on MAC drivers which make
use of the phylink API exported to them.

SFF/SFP/SFP+ MODULE SUPPORT
M:      Russell King <linux@xxxxxxxxxxxxxxx>
L:      netdev@xxxxxxxxxxxxxxx
S:      Maintained
F:      drivers/net/phy/phylink.c
F:      drivers/net/phy/sfp*
F:      include/linux/phylink.h
F:      include/linux/sfp.h
K:      phylink

> $ git grep -P -oh 'phylink_\w+'| sort | uniq -c

Try that again, but skip files matched by the F: clauses.

I suspect the matches you get then more closely approximates the K:
Russell is suggesting.

   Andrew