Re: issue with uninitialized value used in a comparison in gbcodec_mixer_dapm_ctl_put

[Vaibhav Agarwal]

On Wed, Aug 05, 2020 at 08:35:15AM -0500, Alex Elder wrote:

<snip>

> 
> I think the fix is to add a call to this:
> 
>         ret = gb_audio_gb_get_control(module->mgmt_connection, data->ctl_id,
>                                       GB_AUDIO_INVALID_INDEX, &gbvalue);
> 
> before the field within gbvalue is used.
> 
> Looking at gbcodec_mixer_dapm_ctl_get() defined just above that, it
> seems that the call to gb_audio_gb_get_control() should be preceded
> by a call to gb_pm_runtime_get_sync().  And given that duplication,
> I suggest this call and the PM runtime wrapper functions should be
> placed in a new helper function.
> 
> I know that Vaibhav said he would be fixing this, so I guess my
> comments are directed at him.  Thanks for sending the patch Colin.
> 
> 					-Alex

Thanks Alex. I'll share a patch with the proposed fix.

--
vaibhav

> 
> 
> > Colin
> > 
> > 
>