Re: [PATCH] regulator: pwm: Do not print error on probe deferral

[Mark Brown]

On Thu, Aug 06, 2020 at 05:55:15PM +0200, Thierry Reding wrote:

>  	if (IS_ERR(drvdata->enb_gpio)) {
>  		ret = PTR_ERR(drvdata->enb_gpio);
> -		dev_err(&pdev->dev, "Failed to get enable GPIO: %d\n", ret);
> +		if (ret != -EPROBE_DEFER)
> +			dev_err(&pdev->dev, "Failed to get enable GPIO: %d\n", ret);

This will not provide any diagnostics if there's an issue with probe
deferral it'll be hard for people to figure out what's going on.  At
most lower the severity to dev_dbg() but don't totally remove the
logging.

Attachment: signature.asc
Description: PGP signature