Re: [RESEND PATCH] media: atomisp: Replace trace_printk by pr_info

From: Mauro Carvalho Chehab
Date: Fri Aug 07 2020 - 04:04:52 EST


Em Fri, 7 Aug 2020 14:51:12 +0800
Nicolas Boichat <drinkcat@xxxxxxxxxxxx> escreveu:

> On Fri, Aug 7, 2020 at 2:28 PM Greg Kroah-Hartman
> <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > On Fri, Aug 07, 2020 at 09:50:23AM +0800, Nicolas Boichat wrote:
> > > On Fri, Jul 24, 2020 at 8:41 PM Nicolas Boichat <drinkcat@xxxxxxxxxxxx> wrote:
> > > >
> > > > On Fri, Jul 10, 2020 at 3:03 PM Greg Kroah-Hartman
> > > > <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > > > >
> > > > > On Fri, Jul 10, 2020 at 02:45:29PM +0800, Nicolas Boichat wrote:
> > > > > > trace_printk should not be used in production code, replace it
> > > > > > call with pr_info.
> > > > > >
> > > > > > Signed-off-by: Nicolas Boichat <drinkcat@xxxxxxxxxxxx>
> > > > > > ---
> > > > > > Sent this before as part of a series (whose 4th patch was a
> > > > > > change that allows to detect such trace_printk), but maybe it's
> > > > > > easier to get individual maintainer attention by splitting it.
> > > > >
> > > > > Mauro should take this soon:
> > > > >
> > > > > Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > > >
> > > > Mauro: did you get a chance to look at this? (and the other similar
> > > > patch "media: camss: vfe: Use trace_printk for debugging only")
> > >
> > > Mauro: Another gentle ping. Thanks.
> >
> > It's the middle of the merge window, maintainers can't do anything until
> > after 5.9-rc1 is out, sorry.
>
> Huh, wait, looks like Mauro _did_ pick it (found it in this email
> "[GIT PULL for v5.8-rc7] media fixes").
>
> My bad then, I was expecting an ack ,-)

Never expect acks. Kernel maintainers usually don't send them.

Yet, in the case of media, you should probably have received
an automatic e-mail from our patchwork instance.

Thanks,
Mauro