Re: [PATCH 1/2] mm/slub: Introduce two counters for the partial objects
From: Christopher Lameter
Date: Fri Aug 07 2020 - 09:02:46 EST
On Fri, 7 Aug 2020, Pekka Enberg wrote:
> I think we can just default to the counters. After all, if I
> understood correctly, we're talking about up to 100 ms time period
> with IRQs disabled when count_partial() is called. As this is
> triggerable from user space, that's a performance bug whatever way you
> look at it.
Well yes under extreme conditions and this is only happening for sysfs
counter retrieval.
There could be other solutions to this. This solution here is penalizing
evertu hotpath slab allocation for the sake of relatively infrequently
used counter monitoring. There the possibility of not traversing the list
ande simply estimating the value based on the number of slab pages
allocated on that node.
> Christoph, others, any objections?
Obviously .... ;-)