Re: [PATCH v9 2/5] drm/msm/dp: add displayPort driver support

[Randy Dunlap]

On 8/7/20 9:09 AM, Guenter Roeck wrote:
> On Fri, Aug 7, 2020 at 8:37 AM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
>>
>> On 8/7/20 12:17 AM, Tanmay Shah wrote:
>>> diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig
>>> index 6deaa7d01654..ea3c4d094d09 100644
>>> --- a/drivers/gpu/drm/msm/Kconfig
>>> +++ b/drivers/gpu/drm/msm/Kconfig
>>> @@ -57,6 +57,14 @@ config DRM_MSM_HDMI_HDCP
>>>       help
>>>         Choose this option to enable HDCP state machine
>>>
>>> +config DRM_MSM_DP
>>> +     bool "Enable DP support in MSM DRM driver"
>>
>>         bool "Enabled DisplayPort support in MSM DRM driver"
>>
> Why "Enabled" ? This would be quite unusual for a Kconfig entry.

Sorry, my typo.
Just "Enable", like it was earlier.

> Guenter
> 
>>> +     depends on DRM_MSM
>>> +     help
>>> +       Compile in support for DP driver in msm drm driver. DP external
>>
>>                                               MSM DRM
>>
>> Also:
>> I can't find anywhere in drivers/gpu/drm/msm/ that explains what MSM means.
>> What does it mean?
>>
>>> +       display support is enabled through this config option. It can
>>> +       be primary or secondary display on device.
>>> +
>>>  config DRM_MSM_DSI
>>>       bool "Enable DSI support in MSM DRM driver"
>>>       depends on DRM_MSM


-- 
~Randy