Re: [RFC PATCH 0/7] metricfs metric file system and examples

From: Randy Dunlap
Date: Fri Aug 07 2020 - 13:10:52 EST


On 8/5/20 5:14 PM, Jonathan Adams wrote:
> To try to restart the discussion of kernel statistics started by the
> statsfs patchsets (https://lkml.org/lkml/2020/5/26/332), I wanted
> to share the following set of patches which are Google's 'metricfs'
> implementation and some example uses. Google has been using metricfs
> internally since 2012 as a way to export various statistics to our
> telemetry systems (similar to OpenTelemetry), and we have over 200
> statistics exported on a typical machine.
>

Hi,

AFAIK all Linux filesystems (including pseudo/synthetic ones)
live under fs/, not in kernel/.

Therefore I think that this patch series needs more exposure,
i.e., Cc: it to linux-fsdevel@xxxxxxxxxxxxxxx and netdev@xxxxxxxxxxxxxxx.
oh, and to gregkh.


> Jonathan Adams (5):
> core/metricfs: add support for percpu metricfs files
> core/metricfs: metric for kernel warnings
> core/metricfs: expose softirq information through metricfs
> core/metricfs: expose scheduler stat information through metricfs
> core/metricfs: expose x86-specific irq information through metricfs
>
> Justin TerAvest (1):
> core/metricfs: Create metricfs, standardized files under debugfs.
>
> Laurent Chavey (1):
> net-metricfs: Export /proc/net/dev via metricfs.
>
> arch/x86/kernel/irq.c | 80 ++++
> fs/proc/stat.c | 57 +++
> include/linux/metricfs.h | 131 +++++++
> kernel/Makefile | 2 +
> kernel/metricfs.c | 775 +++++++++++++++++++++++++++++++++++++
> kernel/metricfs_examples.c | 151 ++++++++
> kernel/panic.c | 131 +++++++
> kernel/softirq.c | 45 +++
> lib/Kconfig.debug | 18 +
> net/core/Makefile | 1 +
> net/core/net_metricfs.c | 194 ++++++++++
> 11 files changed, 1585 insertions(+)
> create mode 100644 include/linux/metricfs.h
> create mode 100644 kernel/metricfs.c
> create mode 100644 kernel/metricfs_examples.c
> create mode 100644 net/core/net_metricfs.c


thanks.
--
~Randy