Re: [PATCH v4 0/4] iio: temperature: mlx90632: Add extended calibration calculations

[Andy Shevchenko]

On Sat, Aug 8, 2020 at 3:10 PM Crt Mori <cmo@xxxxxxxxxxx> wrote:
>
> Since the second patch is dependent on the first and was still not
> merged, I have decided to send them together. First patch just makes
> second one more readable as it splits out the repeated calculation and
> that enables the second patch to tweak the variable to the new
> condition.

I guess the above is not true anymore, b/c it's already 4 in the series.

Thanks for the changelog, nevertheless!

> V4 review comments from Andy Shevchenko <andy.shevchenko@xxxxxxxxx>:
>          - Move the function creation for Ta4 to first patch
>          - Add kernel doc patch for documenting internal struct
>          - Add patch to convert while loops to do-while loops for
>            polling
>
> V3 review comments from Andy Shevchenko <andy.shevchenko@xxxxxxxxx>:
>          - Change commit message text to more proper English as per suggestions
>          - Drop unneeded brackets and parentheses
>          - Use defines from limits.h
>          - Remove userspace typedefs as leftovers from porting
>          - Testing of timeout loops with iopoll.h was no successful,
>            because delay between measurements is 10ms, but we need to
>            fill at least 3 channels, so final timeout should be 40ms
>            which is out of scope of usleep function
>          - Fixing some typos in comments
>
> V2 review comments from Andy Shevchenko <andy.shevchenko@xxxxxxxxx>:
>          - Convert divison back to shifts to make it more readable
>
> Crt Mori (4):
>   iio:temperature:mlx90632: Reduce number of equal calulcations
>   iio:temperature:mlx90632: Adding extended calibration option
>   iio:temperature:mlx90632: Add kerneldoc to the internal struct
>   iio:temperature:mlx90632: Convert polling while loops to do-while
>
>  drivers/iio/temperature/mlx90632.c | 251 +++++++++++++++++++++++++++--
>  1 file changed, 236 insertions(+), 15 deletions(-)
>
> --
> 2.25.1
>


-- 
With Best Regards,
Andy Shevchenko