RE: [PATCH] tools/thermal: tmon: include pthread and time headers in tmon.h

[Alejandro González]

> > -----Original Message-----
> > From: Florian Fainelli <f.fainelli@xxxxxxxxx>
> > Sent: Thursday, June 18, 2020 8:23 AM
> > To: Markus Mayer <markus.mayer@xxxxxxxxxxxx>; Daniel Lezcano
> > <daniel.lezcano@xxxxxxxxxx>; Pawnikar, Sumeet R
> > <sumeet.r.pawnikar@xxxxxxxxx>; Zhang, Rui <rui.zhang@xxxxxxxxx>; Brian
> > Norris <computersforpeace@xxxxxxxxx>
> > Cc: Broadcom Kernel List <bcm-kernel-feedback-list@xxxxxxxxxxxx>; Linux
> > Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>
> > Subject: Re: [PATCH] tools/thermal: tmon: include pthread and time headers
> > in tmon.h
> > 
> > 
> > 
> > On 6/17/2020 4:58 PM, Markus Mayer wrote:
> > > Include sys/time.h and pthread.h in tmon.h, so that types
> > > "pthread_mutex_t" and "struct timeval tv" are known when tmon.h
> > > references them.
> > >
> > > Without these headers, compiling tmon against musl-libc will fail with
> > > these errors:
> > >
> > > In file included from sysfs.c:31:0:
> > > tmon.h:47:8: error: unknown type name 'pthread_mutex_t'
> > >  extern pthread_mutex_t input_lock;
> > >         ^~~~~~~~~~~~~~~
> > > make[3]: *** [<builtin>: sysfs.o] Error 1
> > > make[3]: *** Waiting for unfinished jobs....
> > > In file included from tui.c:31:0:
> > > tmon.h:54:17: error: field 'tv' has incomplete type
> > >   struct timeval tv;
> > >                  ^~
> > > make[3]: *** [<builtin>: tui.o] Error 1
> > > make[2]: *** [Makefile:83: tmon] Error 2
> > >
> > > Signed-off-by: Markus Mayer <mmayer@xxxxxxxxxxxx>
> > 
> > Acked-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
> > --
> > Florian
> 
> Reviewed-by: Sumeet Pawnikar <sumeet.r.pawnikar@xxxxxxxxx>
> 
> Thanks,
> Sumeet.

I've tested this patch with musl-libc for the same arch. It works like a charm.

Acked-by: Alejandro González <alejandro.gonzalez.correo@xxxxxxxxx>
Tested-by: Alejandro González <alejandro.gonzalez.correo@xxxxxxxxx>