Re: [PATCH] fix arm64 build with lack of __cpu_logical_map exported
From: Sudeep Holla
Date: Mon Aug 10 2020 - 03:45:28 EST
Hi Catalin,
On Sat, Aug 08, 2020 at 04:05:00PM +0100, Catalin Marinas wrote:
> Hi Greg,
>
> On Sat, Aug 08, 2020 at 02:42:42PM +0200, Greg Kroah-Hartman wrote:
> > diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c
> > index 87e81d29e6fb..b421a4756793 100644
> > --- a/arch/arm64/kernel/setup.c
> > +++ b/arch/arm64/kernel/setup.c
> > @@ -275,6 +275,7 @@ static int __init reserve_memblock_reserved_regions(void)
> > arch_initcall(reserve_memblock_reserved_regions);
> >
> > u64 __cpu_logical_map[NR_CPUS] = { [0 ... NR_CPUS-1] = INVALID_HWID };
> > +EXPORT_SYMBOL_GPL(__cpu_logical_map);
>
> This was still under discussion, Sudeep preferring an alternative in the
> driver:
>
> http://lkml.kernel.org/r/20200727172744.GD8003@bogus
> http://lkml.kernel.org/r/20200724131059.GB6521@bogus
>
> Sumit came with a new diff inline that fixes the driver instead of
> exporting the __cpu_logical_map.
>
> https://lore.kernel.org/linux-arm-kernel/e3a4bc21-c334-4d48-90b5-aab8d187939e@xxxxxxxxxx/
>
> Sumit, Sudeep, is the above diff sufficient and can it go upstream?
>
Yes I prefer the above in above thread. I will reply on that thread. Sorry
for missing, been a week.
--
Regards,
Sudeep