Re: [PATCH] usb: gadget: tegra-xudc: Avoid GFP_ATOMIC where it is not needed

From: Thierry Reding
Date: Mon Aug 10 2020 - 10:00:42 EST


On Sun, Aug 09, 2020 at 09:29:48AM +0200, Christophe JAILLET wrote:
> There is no need to use GFP_ATOMIC here. It is a probe function, no
> spinlock is taken.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> ---
> drivers/usb/gadget/udc/tegra-xudc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Looks good to me. I can't think of any reason why this would have to be
an atomic allocation. Nagarjuna, please shout if this is really needed,
otherwise:

Acked-by: Thierry Reding <treding@xxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature